driver: dma: dma_silabs_siwx91x_gpdma: Add pm support #97909
Conversation
Martinhoff-maker
force-pushed
the
gpdma-pm
branch
from
9f7066f to
1963d63
Compare
zephyrbot
added
platform: Silabs
zephyrbot
requested review from
asmellby,
jerome-pouiller,
jhedberg and
teburd
| static void siwx91x_gpdma_pm_policy_state_lock_get(void) | ||
| { | ||
| pm_policy_state_lock_get(PM_STATE_SUSPEND_TO_IDLE, PM_ALL_SUBSTATES); | ||
| pm_policy_state_lock_get(PM_STATE_STANDBY, PM_ALL_SUBSTATES); |
There was a problem hiding this comment.
siwg917.dtsi does not have power-state-name = "standby". So I think this line is a no-op.
| .baseC = (uint32_t)cfg->channel_reg, | ||
| .sramBase = (uint32_t)data->desc_pool->buffer, | ||
| }; | ||
| RSI_GPDMA_HANDLE_T gpdma_handle; |
There was a problem hiding this comment.
A case does not open a new scope. So these declarations are not on top of any scope.
There was a problem hiding this comment.
I'm not aware of any style requirement like that for Zephyr. IMO it's fine to have inline declarations when it helps code readability. If absolutely necessary, one could add braces here:
case PM_DEVICE_ACTION_TURN_ON: {
...
break;
}
case PM_DEVICE_ACTION_TURN_OFF:There was a problem hiding this comment.
Actually, please add the braces at least. I just noticed CI failures due to similar issues elsewhere:
https://github.com/zephyrproject-rtos/zephyr/actions/runs/18721827138/job/53395989790
This commit introduce power management in gpdma driver. Signed-off-by: Martin Hoff <[email protected]>
Martinhoff-maker
force-pushed
the
gpdma-pm
branch
from
1963d63 to
1af1f41
Compare
|
| .baseC = (uint32_t)cfg->channel_reg, | ||
| .sramBase = (uint32_t)data->desc_pool->buffer, | ||
| }; | ||
| RSI_GPDMA_HANDLE_T gpdma_handle; |
There was a problem hiding this comment.
Actually, please add the braces at least. I just noticed CI failures due to similar issues elsewhere:
https://github.com/zephyrproject-rtos/zephyr/actions/runs/18721827138/job/53395989790
5 participants
This commit introduce power management in gpdma driver.