shell: fix deadlock in the bypass function #97916
Open
+11
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pdgendt
previously approved these changes
Oct 20, 2025
jakub-uC
force-pushed
the
jakub/fix-shell-bypass-deadlock
branch
from
4ebb800 to
f9af2f1
Compare
pdgendt
reviewed
Oct 20, 2025
Previously, the bypass() function was called while the shell mutex was still held, preventing the use of shell APIs (e.g. shell_print()) inside the bypass context. This change unlocks the shell mutex before invoking bypass() and locks it again afterwards, restoring proper shell context handling and preventing potential deadlocks. Issue fixed by: roni1234321 Fixes zephyrproject-rtos#97722 Signed-off-by: Jakub Rzeszutko <[email protected]>
jakub-uC
force-pushed
the
jakub/fix-shell-bypass-deadlock
branch
from
f9af2f1 to
c583e35
Compare
pdgendt
approved these changes
Oct 20, 2025
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the
bypass()function was called while the shell mutex was still held, preventing the use of shell APIs (e.g.shell_print()) inside the bypass context.This change unlocks the shell mutex before invoking
bypass()and locks it again afterwards, restoring proper shell context handling and preventing potential deadlocks.Fixes #97722
Signed-off-by: roni1234321