STM32 VENC driver fixes and cleanup #97927
Open
+80
−74
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyrbot
requested review from
FRASTM,
GeorgeCGV,
avolmat-st,
djiatsaf-st,
erwango,
etienne-lms,
gautierg-st,
josuah,
loicpoulain,
marwaiehm-st,
mathieuchopstm and
ngphibang
josuah
previously approved these changes
Oct 20, 2025
hfruchet-st
force-pushed
the
pr-venc-fixes
branch
from
24f5f47 to
2c37e09
Compare
etienne-lms
reviewed
Oct 22, 2025
There was a problem hiding this comment.
For the 3 commits: could you add stm32 in the commit messages header lines? E.g.:
drivers: video: stm32_venc: fix return value
drivers: video: stm32_venc: log an error in case of hardware timeout
drivers: video: stm32_venc: fix coding style
For commit "drivers: video: venc: fix coding style", that are a few other camel case variable names to fix:
in encoder_start(), encoder_end() and encode_frame():
H264EncIn encIn = {0};
H264EncOut encOut = {0};In EWLWaitHwRdy():
uint32_t prevSlicesReady = 0;
(...)
uint32_t clrByWrite1 = ...
hfruchet-st
dismissed stale reviews from ngphibang and avolmat-st
via
45d9bf9
hfruchet-st
force-pushed
the
pr-venc-fixes
branch
2 times, most recently
from
45d9bf9 to
d0d150d
Compare
|
Fix Etienne's remarks about remaining CamelCase and commit header. |
Avoid mixing encoder library return code and driver return value to fix wrong value returned by enqueue() in nominal case. Signed-off-by: Hugues Fruchet <[email protected]>
Log an error in case of hardware timeout. Signed-off-by: Hugues Fruchet <[email protected]>
Fix coding style issues in venc video driver. Signed-off-by: Hugues Fruchet <[email protected]>
hfruchet-st
force-pushed
the
pr-venc-fixes
branch
from
d0d150d to
4a90372
Compare
|
etienne-lms
approved these changes
Oct 22, 2025
avolmat-st
approved these changes
Oct 22, 2025
mathieuchopstm
approved these changes
Oct 22, 2025
erwango
approved these changes
Oct 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix some wrong return code in nominal case, add some error logging in case of timeout and fixes some camel-case coding style issues reported when reviewing #92884.