Skip to content

Conversation

RoyAc6
Copy link

@RoyAc6 RoyAc6 commented Oct 20, 2025

Puncover v0.6.0 renamed the command-line argument
--gcc_tools_base to --gcc-tools-base.

Fixes compatibility error when running west build -t puncover with puncover v0.6.0 or newer.

Signed-off-by: Roy Jamil [email protected]

Copy link

Hello @RoyAc6, and thank you very much for your first pull request to the Zephyr project!
Our Continuous Integration pipeline will execute a series of checks on your Pull Request commit messages and code, and you are expected to address any failures by updating the PR. Please take a look at our commit message guidelines to find out how to format your commit messages, and at our contribution workflow to understand how to update your Pull Request. If you haven't already, please make sure to review the project's Contributor Expectations and update (by amending and force-pushing the commits) your pull request if necessary.
If you are stuck or need help please join us on Discord and ask your question there. Additionally, you can escalate the review when applicable. 😊

@zephyrbot zephyrbot added area: Build System size: XS A PR changing only a single line of code labels Oct 20, 2025
@RoyAc6 RoyAc6 changed the title scripts: puncover: Fix compatibility with v0.6.0 cmake: reports: Fix puncover compatibility with v0.6.0 Oct 20, 2025
@RoyAc6 RoyAc6 force-pushed the fix-puncover-v0.6.0 branch 2 times, most recently from 4cc803f to 48b2425 Compare October 21, 2025 16:30
Signed-off-by: Roy Jamil <[email protected]>

Puncover v0.6.0 renamed the command-line argument
`--gcc_tools_base` to `--gcc-tools-base`.

Fixes compatibility error when running `west build -t puncover`
with puncover v0.6.0 or newer.
@RoyAc6 RoyAc6 force-pushed the fix-puncover-v0.6.0 branch from 48b2425 to 18e288f Compare October 21, 2025 16:46
Copy link

Please retry analysis of this Pull-Request directly on SonarQube Cloud

Copy link
Contributor

@tejlmand tejlmand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved as the changes are correct, but technically the commit message is wrong:

Puncover v0.6.0 renamed the command-line argument
`--gcc_tools_base` to `--gcc-tools-base`.

Puncover v0.3.6 supported both --gcc-tools-base and --gcc_tools_base, so v0.6.0 just removed support for --gcc_tools_base.

This is important detail because it means that this change will not impact users having an older versions of puncover.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: Build System size: XS A PR changing only a single line of code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants