Renesas: Add DTC support for SPI and I2C drivers #97959
Open
+678
−35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@KhiemNguyenT Please do not assign draft PRs, let the bot do the assignment when the PR becomes ready to review. |
Add dtc device support for i2c and spi node Signed-off-by: Quy Tran <[email protected]>
Support DTC transfer for I2C module on rsk_rx130_512kb board Signed-off-by: Minh Tang <[email protected]>
This commit is to add DTC transfer feature for both SPI controller mode and peripheral mode on board RSK-RX130-512KB Signed-off-by: Minh Tang <[email protected]>
quytranpzz
force-pushed
the
rx_support_dtc_spi_i2c
branch
from
19babff to
0045087
Compare
|
zephyrbot
added
area: SPI
tbursztyka
requested changes
Oct 22, 2025
| bool do_rx_now; | ||
| bool do_tx; | ||
| rspi_str_tranmode_t rx_data_tran_mode; | ||
| rspi_str_tranmode_t tx_data_tran_mode; |
| /* dtc device handle */ | ||
| const struct device *dtc; | ||
| /* TX */ | ||
| uint8_t tx_dtc_activation_irq; |
There was a problem hiding this comment.
move the uint8_t at the end
| transfer_info_t tx_dtc_info; | ||
| /* RX */ | ||
| uint8_t rx_dtc_activation_irq; | ||
| transfer_info_t rx_dtc_info; |
| uint8_t slv_addr; | ||
| struct i2c_msg *msgs; | ||
| uint8_t num_msgs; | ||
| uint8_t num_processed_msgs; |
There was a problem hiding this comment.
re-position the attributes for better alignment
| goto end; | ||
| } | ||
| #endif /* CONFIG_SPI_RENESAS_RX_DTC */ | ||
|
|
There was a problem hiding this comment.
I have no idea how dtc works, but you start the transfer above (and you did provide the buffers to it), but here you anyway call the R_RSPI_Write/R_RSPI_Read functions as before? (is it what's really going to trigger the transfer, or is this a mistake?)
JarmouniA
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #93498 merged, add Data Transfer Controller (DTC) support for SPI and I2C driver of Renesas RX