Skip to content

Bluetooth: Fix double set random address for every advertising enable #97974

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Bluetooth: Fix double set random address for every advertising enable #97974

wants to merge 2 commits into from
+13 −2

Conversation

LingaoM
Copy link
Contributor

@LingaoM LingaoM commented Oct 21, 2025

The bt_le_ext_adv_update_param will set new random address when option not select BT_LE_ADV_OPT_USE_IDENTITY, But bt_le_ext_adv_start will also set random address again.

This will be affect bluetooth mesh, after this change, will ensure address only change once for every advertising.

@zephyrbot zephyrbot added the area: Bluetooth Host Bluetooth Host (excluding BR/EDR) label Oct 21, 2025
@LingaoM LingaoM force-pushed the fix_double_set_random_addr branch 2 times, most recently from 7790a4f to a558bcf Compare October 21, 2025 09:23
@zephyrbot zephyrbot added the area: Tests Issues related to a particular existing or missing test label Oct 21, 2025
@LingaoM LingaoM force-pushed the fix_double_set_random_addr branch from 0e7b311 to a558bcf Compare October 21, 2025 10:28
@LingaoM
Copy link
Contributor Author

LingaoM commented Oct 21, 2025

@PavelVPV I am confused about the failure of mesh relay in bbsim?

@alxelax
Copy link
Contributor

alxelax commented Oct 21, 2025 •
edited
Loading

@PavelVPV I am confused about the failure of mesh relay in bbsim?

According to test scenario with multiadvertisement configuration, advertisements should work in parallel. Seems they don't in this PR.

I see @LingaoM is author of test scenario. I guess you know it better than we. :)
#81317

@LingaoM LingaoM force-pushed the fix_double_set_random_addr branch 2 times, most recently from a04b899 to 8659046 Compare October 22, 2025 01:08
@LingaoM LingaoM force-pushed the fix_double_set_random_addr branch from 8659046 to 231ba67 Compare October 22, 2025 01:21
@LingaoM
Bluetooth: Fix double set random address for every advertising enable
bd47268 
The `bt_le_ext_adv_update_param` will set new random address when option
not select `BT_LE_ADV_OPT_USE_IDENTITY`, But `bt_le_ext_adv_start` will
also set random address again.

This will be affect bluetooth mesh, after this change, will ensure address
only change once for every advertising.

Signed-off-by: Lingao Meng <[email protected]>
@LingaoM
tests: bluetooth: mesh: fix bbsim timing
a7b7c06 
fix bluetooth mesh relay timing problem.

Signed-off-by: Lingao Meng <[email protected]>
@LingaoM LingaoM force-pushed the fix_double_set_random_addr branch 2 times, most recently from 38589d6 to a7b7c06 Compare October 22, 2025 02:47
@LingaoM
Copy link
Contributor Author

LingaoM commented Oct 22, 2025 •
edited
Loading

@alxelax For Mesh bbsim problem, it's look like not problem, just timing changed.

For PAST bbsim, even i revert these change, bbsim also not pass.

CC @lutb-ot #78894

d_02: @00:00:01.152593  [DEVICE]: ED:C7:E9:55:8A:4B (random), AD evt type 4, Tx Pwr: 127, RSSI -59  C:1 S:1 D:0 SR:1 E:0 Prim: LE 1M, Secn: No packets, Interval: 0x0000 (0 ms), SID: 255
d_02: @00:00:01.184836  [DEVICE]: ED:C7:E9:55:8A:4B (random), AD evt type 0, Tx Pwr: 127, RSSI -59  C:1 S:1 D:0 SR:0 E:0 Prim: LE 1M, Secn: No packets, Interval: 0x0000 (0 ms), SID: 255
d_02: @00:00:01.185440  [DEVICE]: ED:C7:E9:55:8A:4B (random), AD evt type 4, Tx Pwr: 127, RSSI -59  C:1 S:1 D:0 SR:1 E:0 Prim: LE 1M, Secn: No packets, Interval: 0x0000 (0 ms), SID: 255
d_02: @00:00:01.213796  PER_ADV_SYNC[0]: [DEVICE]: 24:E6:E0:E4:C5:A3 (random) synced, Interval 0x03c0 (1200 ms), PHY LE 2M
d_02: @00:00:01.213796  Stop scanning
d_02: @00:00:01.213796  success.
d_02: @00:00:01.213796  success.
d_02: @00:00:01.213796  Scanning for peripheral
d_02: @00:00:01.213796  success.
d_02: @00:00:01.213796  Waiting for connection...
d_02: @00:00:01.224357  [DEVICE]: ED:C7:E9:55:8A:4B (random), AD evt type 0, AD data len 11, RSSI -59
d_02: @00:00:01.224357  [AD]: 1 data_len 1
d_02: @00:00:01.224357  [AD]: 3 data_len 6
d_02: @00:00:01.224605  [DEVICE]: ED:C7:E9:55:8A:4B (random), AD evt type 0, Tx Pwr: 127, RSSI -59  C:1 S:1 D:0 SR:0 E:0 Prim: LE 1M, Secn: No packets, Interval: 0x0000 (0 ms), SID: 255
d_00: @00:00:01.262273  Connected: F2:B7:8E:FC:DA:91 (random)
d_00: @00:00:01.262273  success.
d_00: @00:00:01.262273  Wait 20s for Periodic advertisement sync to be established
d_02: @00:00:01.262270  Connected: ED:C7:E9:55:8A:4B (random)
d_02: @00:00:01.262270  success.
d_02: @00:00:01.362305  Connection established - sending PAST
d_02: @00:00:01.362305  success.
d_02: @00:00:01.362305  Wait 20s for PAST to be send
d_00: @00:00:21.262299 ERROR: (ZEPHYR_BASE/tests/bsim/bluetooth/ll/bis/src/test_past.c:712): failed (err -11)
d_00: @00:00:21.262299  The TESTCASE FAILED (test return code 2)
d_01: @00:00:21.242797  TESTCASE NOT PASSED at exit (test return (1) indicates it was still in progress)
d_02: @00:00:21.263524  TESTCASE NOT PASSED at exit (test return (1) indicates it was still in progress)
/home/mi/works/github/zephyrproject/zephyr/tests/bsim/bluetooth/ll/bis/tests_scripts/broadcast_iso_interleaved.sh PASSED
/home/mi/works/github/zephyrproject/zephyr/tests/bsim/bluetooth/ll/bis/tests_scripts/past_send_from_broadcaster.sh PASSED
/home/mi/works/github/zephyrproject/zephyr/tests/bsim/bluetooth/ll/bis/tests_scripts/broadcast_iso_scan_aux_use_chains.sh PASSED
/home/mi/works/github/zephyrproject/zephyr/tests/bsim/bluetooth/ll/bis/tests_scripts/broadcast_iso_sequential.sh PASSED
(.venv-3.10) ╭─mi@lingao ~/works/github/zephyrproject/zephyr  ‹4a2140c81be*› 
╰─➤

@sonarqubecloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alwa-nordic alwa-nordic Awaiting requested review from alwa-nordic

@cvinayak cvinayak Awaiting requested review from cvinayak

@HaavardRei HaavardRei Awaiting requested review from HaavardRei

@hermabe hermabe Awaiting requested review from hermabe

@jhedberg jhedberg Awaiting requested review from jhedberg

@PavelVPV PavelVPV Awaiting requested review from PavelVPV

@rugeGerritsen rugeGerritsen Awaiting requested review from rugeGerritsen

@sjanc sjanc Awaiting requested review from sjanc

@Thalley Thalley Awaiting requested review from Thalley

@akredalen akredalen Awaiting requested review from akredalen

@alxelax alxelax Awaiting requested review from alxelax

@Andrewpini Andrewpini Awaiting requested review from Andrewpini

@KyraLengfeld KyraLengfeld Awaiting requested review from KyraLengfeld

@nashif nashif Awaiting requested review from nashif

@omkar3141 omkar3141 Awaiting requested review from omkar3141

At least 2 approving reviews are required to merge this pull request.

Assignees

@jhedberg jhedberg

@alwa-nordic alwa-nordic

Labels

area: Bluetooth Controller area: Bluetooth Host Bluetooth Host (excluding BR/EDR) area: Bluetooth Mesh area: Bluetooth area: Tests Issues related to a particular existing or missing test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@LingaoM @alxelax @jhedberg @zephyrbot @alwa-nordic