Skip to content

driver: peci: npcx: prevent sleep during PECI transactions #97975

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 21, 2025
Merged

driver: peci: npcx: prevent sleep during PECI transactions #97975

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions drivers/peci/peci_npcx.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
#include <zephyr/drivers/clock_control.h>
#include <zephyr/drivers/peci.h>
#include <zephyr/drivers/pinctrl.h>
#include <zephyr/pm/policy.h>
#include <zephyr/kernel.h>

#include <zephyr/logging/log.h>
Expand Down Expand Up @@ -141,6 +142,12 @@ static int peci_npcx_transfer(const struct device *dev, struct peci_msg *msg)
enum peci_command_code cmd_code = msg->cmd_code;
int ret = 0;

/*
* suspend-to-idle stops PECI module clocks (derived from APB2), which
* must remain active during a transaction
*/
pm_policy_state_lock_get(PM_STATE_SUSPEND_TO_IDLE, PM_ALL_SUBSTATES);

k_sem_take(&data->lock, K_FOREVER);

if (peci_tx_buf->len > PECI_NPCX_MAX_TX_BUF_LEN ||
Expand Down Expand Up @@ -194,6 +201,7 @@ static int peci_npcx_transfer(const struct device *dev, struct peci_msg *msg)

out:
k_sem_give(&data->lock);
pm_policy_state_lock_put(PM_STATE_SUSPEND_TO_IDLE, PM_ALL_SUBSTATES);
return ret;
}

Expand Down