tests: remove misuse of snippets #97986
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyrbot
added
area: Tests
Tests cases which needs to apply a single overlay file for testing should not use snippets. Cleanup the test case by reordering the snippet to be SoC specific and adjust overlay selection using FILE_SUFFIX. Signed-off-by: Torsten Rasmussen <[email protected]>
tejlmand
force-pushed
the
tests/snippets_cleanup_gpio_loopback
branch
from
3a07e44 to
478c271
Compare
|
Why removing bl54l15_dvk_nrf54l15_cpuapp.overlay? |
nordicjm
approved these changes
Oct 21, 2025
because it uses Soc files which means it will apply for any nrf54l15 SoC |
because there's a common SoC overlay, |
nordic-piks
approved these changes
Oct 21, 2025
nashif
approved these changes
Oct 21, 2025
nordic-segl
approved these changes
Oct 21, 2025
|
bjarki-andreasen
approved these changes
Oct 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests cases which needs to apply a single overlay file for testing should not use snippets.
Cleanup the test case by reordering the snippet to be SoC specific and adjust overlay selection using FILE_SUFFIX.