lib, kernel: use single evaluation min/max/clamp #98015
Merged
+39
−39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabiobaltieri
force-pushed
the
libkernel-minmax
branch
from
1890cdf to
35203b1
Compare
Replace all in-function instances of MIN/MAX/CLAMP with the single evaluation version min/max/clamp. There's probably no race conditions in these files, but the single evaluation ones save a couple of instructions each so they should save few code bytes and potentially perform better, so they should be preferred in general. Signed-off-by: Fabio Baltieri <[email protected]>
fabiobaltieri
force-pushed
the
libkernel-minmax
branch
from
35203b1 to
780f402
Compare
|
zephyrbot
added
area: Networking Buffers
zephyrbot
requested review from
TaiJuWu,
aescolar,
andyross,
ceolin,
cfriedt,
dcpleung,
jhedberg,
jukkar,
keith-packard,
nashif,
npitre,
peter-mitsis,
rlubos,
stephanosio and
ycsin
jhedberg
approved these changes
Oct 21, 2025
pdgendt
approved these changes
Oct 22, 2025
maass-hamburg
approved these changes
Oct 22, 2025
|
@andyross @peter-mitsis you okay with this? Trying to get it in before the freeze |
peter-mitsis
approved these changes
Oct 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace all in-function instances of MIN/MAX/CLAMP with the single evaluation version min/max/clamp.
There's probably no race conditions in these files, but the single evaluation ones save a couple of instructions each so they should save few code bytes and potentially perform better, so they should be preferred in general.