dfu: Kconfig: fix MCUBoot UPDATE_FOOTER_SIZE build warning #98027
+9
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MCUBOOT_UPDATE_FOOTER_SIZE depends on MCUBOOT_IMG_MANAGER on Zephyr side, but Sysbuild tries to set it always on MCUboot side which results in the following annoying warning when building with IMG_MANAGER=n: "warning: MCUBOOT_UPDATE_FOOTER_SIZE (defined at subsys/dfu/Kconfig:55) was assigned the value '0x30' but got the value ''. Check these unsatisfied dependencies: MCUBOOT_IMG_MANAGER (=n), IMG_MANAGER (=n)" Since we cannot condition MCUBOOT_UPDATE_FOOTER_SIZE's use by Sysbuild on MCUboot side, because "it sets the config of the application before the application is configured...we cannot read any application configuration" at that moment (see [1] for the full quote), remove MCUBOOT_UPDATE_FOOTER_SIZE's dependence on MCUBOOT_IMG_MANAGER and make it depend on BOOTLOADER_MCUBOOT only. The symbol help text still says that it is only useful when MCUBOOT_IMG_MANAGER and MCUMGR_GRP_IMG_TOO_LARGE_SYSBUILD are set. [1] mcu-tools/mcuboot#2504 (comment) Signed-off-by: Abderrahmane JARMOUNI <[email protected]>
|
nordicjm
reviewed
Oct 22, 2025
|
|
||
| endif # IMG_MANAGER | ||
|
|
||
| config MCUBOOT_UPDATE_FOOTER_SIZE |
There was a problem hiding this comment.
Not acceptable, the dependency is for MCUBOOT_IMG_MANAGER not just if MCUboot is enabled, see #90721
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CONFIG_MCUBOOT_UPDATE_FOOTER_SIZEdepends onCONFIG_MCUBOOT_IMG_MANAGERon Zephyr side, but Sysbuild tries to set it always on MCUboot side [1] which results in the following annoying warning when building with IMG_MANAGER=n:"warning: MCUBOOT_UPDATE_FOOTER_SIZE (defined at subsys/dfu/Kconfig:55) was assigned the value '0x30' but got the value ''. Check these unsatisfied dependencies: MCUBOOT_IMG_MANAGER (=n), IMG_MANAGER (=n)"
Since we cannot condition
MCUBOOT_UPDATE_FOOTER_SIZE's use by Sysbuild on MCUboot side, because "it sets the config of the application before the application is configured...we cannot read any application configuration" at that moment (see [2] for the full quote), removeMCUBOOT_UPDATE_FOOTER_SIZE's dependence onMCUBOOT_IMG_MANAGERand make it depend onBOOTLOADER_MCUBOOTonly.The symbol help text still says that it is only useful when
MCUBOOT_IMG_MANAGERandMCUMGR_GRP_IMG_TOO_LARGE_SYSBUILDare set.[1] https://github.com/mcu-tools/mcuboot/blob/e4fc5ae221cee2ce9f1120afc2092a693ac5e8a2/boot/zephyr/sysbuild/CMakeLists.txt#L39
[2] mcu-tools/mcuboot#2504 (comment)
This is an alternative to mcu-tools/mcuboot#2504