Skip to content

drivers: fuel_gauge: ltc2959: Fix build warnings from declarations #98107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cfriedt merged 1 commit into from
Oct 22, 2025
Merged

drivers: fuel_gauge: ltc2959: Fix build warnings from declarations #98107

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 12 additions & 12 deletions drivers/fuel_gauge/ltc2959/ltc2959.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -461,7 +461,7 @@ static int ltc2959_get_prop(const struct device *dev, fuel_gauge_prop_t prop,
int ret;

switch (prop) {
case FUEL_GAUGE_STATUS:
case FUEL_GAUGE_STATUS: {
uint8_t raw_st;

ret = i2c_reg_read_byte_dt(&cfg->i2c, LTC2959_REG_STATUS, &raw_st);
Expand All @@ -473,8 +473,8 @@ static int ltc2959_get_prop(const struct device *dev, fuel_gauge_prop_t prop,
val->fg_status = raw_st;

break;

case FUEL_GAUGE_VOLTAGE:
}
case FUEL_GAUGE_VOLTAGE: {
uint16_t raw_voltage;

ret = ltc2959_read16(dev, LTC2959_REG_VOLTAGE_MSB, &raw_voltage);
Expand All @@ -490,8 +490,8 @@ static int ltc2959_get_prop(const struct device *dev, fuel_gauge_prop_t prop,
val->voltage = raw_voltage * LTC2959_VOLT_UV_SF;

return 0;

case FUEL_GAUGE_CURRENT:
}
case FUEL_GAUGE_CURRENT: {
uint16_t raw_current;

ret = ltc2959_read16(dev, LTC2959_REG_CURRENT_MSB, &raw_current);
Expand All @@ -506,8 +506,8 @@ static int ltc2959_get_prop(const struct device *dev, fuel_gauge_prop_t prop,
val->current = current_raw * cfg->current_lsb_ua;

break;

case FUEL_GAUGE_TEMPERATURE:
}
case FUEL_GAUGE_TEMPERATURE: {
uint16_t raw_temp;

ret = ltc2959_read16(dev, LTC2959_REG_TEMP_MSB, &raw_temp);
Expand All @@ -525,8 +525,8 @@ static int ltc2959_get_prop(const struct device *dev, fuel_gauge_prop_t prop,
*/
val->temperature = ((uint32_t)raw_temp * LTC2959_TEMP_K_SF) >> 16;
break;

case FUEL_GAUGE_REMAINING_CAPACITY:
}
case FUEL_GAUGE_REMAINING_CAPACITY: {
uint32_t acr;

ret = ltc2959_read_acr(dev, &acr);
Expand All @@ -537,7 +537,7 @@ static int ltc2959_get_prop(const struct device *dev, fuel_gauge_prop_t prop,

val->remaining_capacity = ltc2959_counts_to_uah(acr, cfg);
break;

}
case FUEL_GAUGE_ADC_MODE:
ret = ltc2959_get_adc_mode(dev, &val->adc_mode);
break;
Expand Down Expand Up @@ -636,15 +636,15 @@ static int ltc2959_set_prop(const struct device *dev, fuel_gauge_prop_t prop,
ret = ltc2959_set_cc_config(dev, val.cc_config);
break;

case FUEL_GAUGE_REMAINING_CAPACITY:
case FUEL_GAUGE_REMAINING_CAPACITY: {
uint32_t counts = ltc2959_uah_to_counts(val.remaining_capacity, cfg);

if (counts == LTC2959_ACR_CLR) {
counts = LTC2959_ACR_CLR - 1;
}
ret = ltc2959_write_acr(dev, counts);
break;

}
default:
ret = -ENOTSUP;
break;
Expand Down