boards: sifli: add sf32lb52_devkit_lcd revisions #98914
Conversation
|
Hello @HalfSweet, and thank you very much for your first pull request to the Zephyr project! |
zephyrbot
added
area: Boards/SoCs
area: West
zephyrbot
requested review from
MaureenHelm,
cameled,
carlescufi,
ck-telecom,
gmarull,
marc-hb,
mbolivar,
nashif,
pdgendt,
stephanosio and
swinslow
gmarull
left a comment
gmarull
left a comment
There was a problem hiding this comment.
please split changed into independent commits
| if(NOT DEFINED BOARD_REVISION) | ||
| set(BOARD_REVISION "n16r8") | ||
| else() | ||
| if(NOT BOARD_REVISION IN_LIST BOARD_REVISIONS) | ||
| message(FATAL_ERROR "${BOARD_REVISION} is not a valid revision for sf32lb52_devkit_lcd. Accepted revisions: ${BOARD_REVISIONS}") | ||
| endif() | ||
| endif() |
There was a problem hiding this comment.
is needed for custom board revisions
There was a problem hiding this comment.
doesn't build system complain if one provides an invalid board revision?
There was a problem hiding this comment.
not with custom, custom basically means the revision.cmake file defines the revisions, the ones in board.yml will just be listed by the list boards python script
There was a problem hiding this comment.
Is there anything else I need to modify here? I've noticed similar wording in some other board variants.
For example: https://github.com/zephyrproject-rtos/zephyr/blob/main/boards/arduino/uno_r4/revision.cmake
HalfSweet
force-pushed
the
sf32lb52_lcd
branch
from
8956afb to
841093e
Compare
| if(NOT DEFINED BOARD_REVISION) | ||
| set(BOARD_REVISION "n16r8") | ||
| else() | ||
| if(NOT BOARD_REVISION IN_LIST BOARD_REVISIONS) | ||
| message(FATAL_ERROR "${BOARD_REVISION} is not a valid revision for sf32lb52_devkit_lcd. Accepted revisions: ${BOARD_REVISIONS}") | ||
| endif() | ||
| endif() |
There was a problem hiding this comment.
is needed for custom board revisions
| default: "n16r8" | ||
| revisions: | ||
| - name: "n16r8" | ||
| - name: "a128r8" |
There was a problem hiding this comment.
Yes, currently the bootrom transfers code to SRAM for execution.
Of course, this isn't a perfect solution. In future updates, I'll add memc drivers to support PSRAM and integrate MCUBoot adaptation to enable running larger code sizes from NAND storage
There was a problem hiding this comment.
does this variant have the NOR defined in board dts files?
- declare n16r8 (default) and a128r8 revisions in board.yml - add revision.cmake to validate BOARD_REVISION and keep n16r8 as fallback Signed-off-by: Haoran Jiang <[email protected]>
HalfSweet
force-pushed
the
sf32lb52_lcd
branch
from
841093e to
c4c990d
Compare
|
7 participants
Uh oh!
There was an error while loading. Please reload this page.