runners: add and improve QEMU runner (Python-based replacement for qemu.cmake) #99170
+187
−26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyrbot
requested review from
carlescufi,
marc-hb,
mbolivar,
pdgendt and
swinslow
Contributor
|
Please fix compliance and CI issues, also since you considerately modified the file, remove it from the ruff excludes file and format it using Line 1415 in 13daf24 |
ritesh006
force-pushed
the
feat/qemu-runner-starter
branch
from
7ef3765 to
100ca60
Compare
zephyrbot
requested review from
57300,
jeremybettis,
kartben,
keith-zephyr,
nashif,
nordicjm and
tejlmand
ritesh006
force-pushed
the
feat/qemu-runner-starter
branch
from
100ca60 to
ff8dfb9
Compare
ritesh006
force-pushed
the
feat/qemu-runner-starter
branch
2 times, most recently
from
995f3dc to
d4d7316
Compare
Contributor
Author
please take a look |
ritesh006
force-pushed
the
feat/qemu-runner-starter
branch
from
d4d7316 to
a8e0305
Compare
nordicjm
requested changes
Nov 17, 2025
cmake/emu/qemu.cmake
Outdated
| list(APPEND QEMU_FLAGS | ||
| -icount shift=${CONFIG_QEMU_ICOUNT_SHIFT},align=off,sleep=on | ||
| -rtc clock=vm) | ||
| -icount shift=${CONFIG_QEMU_ICOUNT_SHIFT},align=off,sleep=on |
Contributor
There was a problem hiding this comment.
these changes are not valid with this alignment
ritesh006
force-pushed
the
feat/qemu-runner-starter
branch
2 times, most recently
from
044ccd6 to
45995c3
Compare
ritesh006
force-pushed
the
feat/qemu-runner-starter
branch
from
45995c3 to
26b0e4c
Compare
- Add scripts/west_commands/runners/qemu.py: starter ZephyrBinaryRunner for QEMU. - Add cmake/emu/qemu.cmake shim that warns about deprecation. - Add short note doc/contrib/qemu_runner_note.rst. Fixes: zephyrproject-rtos#5501 Signed-off-by: Ritesh Kudkelwar <[email protected]>
ritesh006
force-pushed
the
feat/qemu-runner-starter
branch
from
26b0e4c to
31b7a63
Compare
|
Please retry analysis of this Pull-Request directly on SonarQube Cloud |
pdgendt
requested changes
Dec 8, 2025
Comment on lines
+77
to
+80
| if not qemu_bin or not shutil.which(qemu_bin): | ||
| raise RuntimeError( | ||
| "QEMU binary not found: set --qemu-binary or install qemu-system-* on PATH" | ||
| ) |
Contributor
There was a problem hiding this comment.
Use self.require(qemu_bin) instead?
|
|
||
| class QemuBinaryRunner(ZephyrBinaryRunner): | ||
| '''Place-holder for QEMU runner customizations.''' | ||
| log = logging.getLogger(__name__) |
Contributor
There was a problem hiding this comment.
Runners already have a logger, as self.logger.
Comment on lines
+130
to
+140
| def _platform_defaults(self): | ||
| # Minimal defaults. Extend per-board: memory, machine type etc. | ||
| # For common x86 qemu_x86: use -M pc -m 512M -nographic | ||
| board = (self.cfg.board or "").lower() if hasattr(self.cfg, "board") else "" | ||
| if "qemu_x86" in board or "qemu_x86" in str(self.cfg.board_dir): | ||
| return ["-M", "pc", "-m", "512", "-nographic"] | ||
| # cortex-m3 qemu example: | ||
| if "cortex_m3" in board or "qemu_cortex_m3" in str(self.cfg.board_dir): | ||
| return ["-M", "lm3s6965evb", "-nographic"] | ||
| # fall back to minimal no-graphic | ||
| return ["-nographic"] |
Contributor
There was a problem hiding this comment.
This should not be done here, but instead passed as arguments from the boards. Search board_runner_args for examples.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a Python-based QEMU runner (
scripts/west_commands/runners/qemu.py)as part of the effort to deprecate the legacy
cmake/emu/qemu.cmake.Key points:
west runintegrationTested on:
qemu_x86board runningsamples/hello_world(successful boot and output)This addresses part of zephyrproject-rtos/zephyr#5501
and sets the foundation for full migration from CMake to Python-based QEMU runner.