[backport-4.1] manual backport of commit 7c0e4aecace9287bcd0508e991672a732fc95ddc #99606
+8
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cherry picking 7c0e4ae from main branch to ensure test correctly runs in CI. Wait for prompt before sending command to ensure shell is ready. Signed-off-by: Tim Pambor <[email protected]>
kartben
force-pushed
the
backport_sensor_shell_fix
branch
from
9d45eb8 to
212526b
Compare
kartben
changed the title
|
Contributor
Contributor
Contributor
Author
Contributor
|
Cc @tpambor Just in case you could help. |
Contributor
|
The problem was in the and the test here does not fail for native_sim, so that I think that this is probably a different issue here. |
fabiobaltieri
approved these changes
Nov 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to fix a test that works fine on a local computer but not in CI. This is currently preventing CI on 4.1 branch from being green.
I have confirmed in an earlier push that a dummy change to the samples/sensor/sensor_shell/pytest/test_sensor_shell.py file triggers the test ... and it fails. The second push with the cherrypicked commit makes CI happy.