Skip to content

Conversation

@kartben
Copy link
Contributor

@kartben kartben commented Nov 23, 2025

Macros with very generic names like DEVICE_ID are really not ideal so prefix them all with GT911_.
Fixes CI issues in weekly run due to some STM HALs already defining DEVICE_ID:

"error: \"DEVICE_ID\" redefined [-Werror]": {
    "quantity": 9,
    "tests": [
        "stm32mp135f_dk/stm32mp135fxx:input.api.synchronous",
        "stm32mp135f_dk/stm32mp135fxx:input.api.thread",
        "stm32mp135f_dk/stm32mp135fxx:sample.modules.lvgl.demo_benchmark",
        "stm32mp135f_dk/stm32mp135fxx:sample.modules.lvgl.demo_benchmark.lvgl_auto",
        "stm32mp135f_dk/stm32mp135fxx:sample.modules.lvgl.demo_keypad_encoder",
        "stm32mp135f_dk/stm32mp135fxx:sample.modules.lvgl.demo_music",
        "stm32mp135f_dk/stm32mp135fxx:sample.modules.lvgl.demo_render",
        "stm32mp135f_dk/stm32mp135fxx:sample.modules.lvgl.demo_stress",
        "stm32mp135f_dk/stm32mp135fxx:sample.modules.lvgl.demo_widgets"
    ],
    "subcounters": {
        "counters": {}
    }
},

simple repro:

west build -b stm32mp135f_dk/stm32mp135fxx samples/modules/lvgl/demos -p

macros with very generic name like DEVICE_ID are really not ideal so
prefix them all with GT911_.

Signed-off-by: Benjamin Cabé <[email protected]>
@sonarqubecloud
Copy link

@kartben kartben marked this pull request as ready for review November 23, 2025 19:57
@zephyrbot zephyrbot added the area: Input Input Subsystem and Drivers label Nov 23, 2025
@kartben kartben requested a review from faxe1008 November 23, 2025 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: Input Input Subsystem and Drivers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants