Skip to content

include: ec_host_cmd: minor tweaks #99874

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
+45 −2
Open

include: ec_host_cmd: minor tweaks #99874

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
397596a
include: ec_host_cmd: add a request and response only handler macros
fabiobaltieri Nov 23, 2025
07a93c1
include: ec_host_cmd: add an extra _ on handler structs
fabiobaltieri Nov 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
47 changes: 45 additions & 2 deletions include/zephyr/mgmt/ec_host_cmd/ec_host_cmd.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -222,14 +222,57 @@ struct ec_host_cmd_handler {
* @a _function.
*/
#define EC_HOST_CMD_HANDLER(_id, _function, _version_mask, _request_type, _response_type) \
const STRUCT_SECTION_ITERABLE(ec_host_cmd_handler, __cmd##_id) = { \
const STRUCT_SECTION_ITERABLE(ec_host_cmd_handler, __cmd_##_id) = { \
.handler = _function, \
.id = _id, \
.version_mask = _version_mask, \
.min_rqt_size = sizeof(_request_type), \
.min_rsp_size = sizeof(_response_type), \
}

/**
* @brief Statically define and register a request only host command handler.
*
* Helper macro to statically define and register a host command handler that
* has a compile-time-fixed size for its request structure.
*
* @param _id Id of host command to handle request for.
* @param _function Name of handler function.
* @param _version_mask The bitfield of all versions that the @a _function
* supports. E.g. BIT(0) corresponds to version 0.
* @param _request_type The datatype of the request parameters for @a _function.
*/
#define EC_HOST_CMD_HANDLER_REQ_ONLY(_id, _function, _version_mask, _request_type) \
const STRUCT_SECTION_ITERABLE(ec_host_cmd_handler, __cmd_##_id) = { \
.handler = _function, \
.id = _id, \
.version_mask = _version_mask, \
.min_rqt_size = sizeof(_request_type), \
.min_rsp_size = 0, \
}

/**
* @brief Statically define and register a responsy only host command handler.
*
* Helper macro to statically define and register a host command handler that
* has a compile-time-fixed sizes for its response structure.
*
* @param _id Id of host command to handle request for.
* @param _function Name of handler function.
* @param _version_mask The bitfield of all versions that the @a _function
* supports. E.g. BIT(0) corresponds to version 0.
* @param _response_type The datatype of the response parameters for
* @a _function.
*/
#define EC_HOST_CMD_HANDLER_RESP_ONLY(_id, _function, _version_mask, _response_type) \
const STRUCT_SECTION_ITERABLE(ec_host_cmd_handler, __cmd_##_id) = { \
.handler = _function, \
.id = _id, \
.version_mask = _version_mask, \
.min_rqt_size = 0, \
.min_rsp_size = sizeof(_response_type), \
}

/**
* @brief Statically define and register a host command handler without sizes.
*
Expand All @@ -242,7 +285,7 @@ struct ec_host_cmd_handler {
* supports. E.g. BIT(0) corresponds to version 0.
*/
#define EC_HOST_CMD_HANDLER_UNBOUND(_id, _function, _version_mask) \
const STRUCT_SECTION_ITERABLE(ec_host_cmd_handler, __cmd##_id) = { \
const STRUCT_SECTION_ITERABLE(ec_host_cmd_handler, __cmd_##_id) = { \
.handler = _function, \
.id = _id, \
.version_mask = _version_mask, \
Expand Down