Open
Conversation
Contributor
Author
|
Evidences of success: ConfigCache BEFORE the fix:ConfigCache AFTER the fix:Note also the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes #103
The problem is not incorrect syntax (the patches are syntactically correct!), neither a collateral effect from using
:NEEDS[foo]:FOR[foo], that when applied to a patch on a different directory thanfoocan cause trouble, but not this one.The problem is data being patched twice, simple like that.
I deleted the one that I found less sound, trying to be the less intrusive possible to solve the issue at hands.