Skip to content

Fixes #103#104

Open
Lisias wants to merge 2 commits intozer0Kerbal:masterfrom
net-lisias-kspw:pull-requests/to/upstream/2
Open

Fixes #103#104
Lisias wants to merge 2 commits intozer0Kerbal:masterfrom
net-lisias-kspw:pull-requests/to/upstream/2

Conversation

@Lisias
Copy link
Contributor

@Lisias Lisias commented Mar 2, 2025

This pull request fixes #103

The problem is not incorrect syntax (the patches are syntactically correct!), neither a collateral effect from using :NEEDS[foo]:FOR[foo], that when applied to a patch on a different directory than foo can cause trouble, but not this one.

The problem is data being patched twice, simple like that.

I deleted the one that I found less sound, trying to be the less intrusive possible to solve the issue at hands.

@Lisias Lisias changed the title Fixes https://github.com/zer0Kerbal/OnDemandFuelCells/issues/103 Fixes #103 Mar 2, 2025
@Lisias
Copy link
Contributor Author

Lisias commented Mar 2, 2025

Evidences of success:

ConfigCache BEFORE the fix:

UrlConfig
{
    parentUrl = Squad/Parts/Science/LargeCrewedLab/largeCrewedLab.cfg
    PART
    {
        name = Large_Crewed_Lab
        module = Part
        author = Squad
        mesh = large_crewed_lab.mu
        rescaleFactor = 1
        node_stack_top = 0.0, 1.825, 0.0, 0.0, 1.0, 0.0, 2
        node_stack_bottom = 0.0, -1.831, 0.0, 0.0, -1.0, 0.0, 2
        CrewCapacity = 2
        TechRequired = advExploration
        entryCost = 10400
        cost = 4100                                           <---- HERE!
        category = Science
        subcategory = 0
        title = Mobile Processing Lab MPL-LG-2 <color=#6495ED> ODFC</color> <color=#6495ED> ODFC</color>
        manufacturer = Integrated Integrals
        description = No longer are you limited to research facilities only on Kerbin!  With the Mobile Processing Lab, you can conduct long-term experiments
        attachRules = 1,0,1,1,0
        mass = 3.511                                           <---- HERE!

ConfigCache AFTER the fix:

UrlConfig
{
    parentUrl = Squad/Parts/Science/LargeCrewedLab/largeCrewedLab.cfg
    PART
    {
        name = Large_Crewed_Lab
        module = Part
        author = Squad
        mesh = large_crewed_lab.mu
        rescaleFactor = 1
        node_stack_top = 0.0, 1.825, 0.0, 0.0, 1.0, 0.0, 2
        node_stack_bottom = 0.0, -1.831, 0.0, 0.0, -1.0, 0.0, 2
        CrewCapacity = 2
        TechRequired = advExploration
        entryCost = 10400
        cost = 4050                                           <---- HERE!
        category = Science
        subcategory = 0
        title = Mobile Processing Lab MPL-LG-2 <color=#6495ED> ODFC</color>
        manufacturer = Integrated Integrals
        description = No longer are you limited to research facilities only on Kerbin!  With the Mobile Processing Lab, you can conduct long-term experiments
        attachRules = 1,0,1,1,0
        mass = 3.501                                           <---- HERE!

Note also the title.

@zer0Kerbal zer0Kerbal self-requested a review March 3, 2025 02:20
@zer0Kerbal zer0Kerbal added the bug 🐛 An issue with the system. Something isn't working... KSC... we have an error code label Mar 3, 2025
@zer0Kerbal zer0Kerbal added this to the 1.2.99.2-prerelease milestone Mar 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug 🐛 An issue with the system. Something isn't working... KSC... we have an error code

Projects

Development

Successfully merging this pull request may close these issues.

[Bug 🐞]: Incorrect syntax in patch results in double patch

2 participants