Allow specifying custom header values when fetching rule list #260
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cyqsimon
commented
Dec 25, 2025
Author
There was a problem hiding this comment.
xhrWrapper currently doesn't handle other 4xx errors (most notably 401 and 403), and instead treat those as success. Obviously this isn't ideal, but this belongs in a separate PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Currently you can specify a URL for the rule list of each switch profile, but said URL has to be publicly accessible. Due to the potentially-sensitive nature of the rule list, it would be nice to support authenticated sources too.
This PR adds the ability to add custom header values to the fetch, which allows the user to specify things like an authorization header. This would enable, for example, fetching the rule list from a private gist or repository.
Compatibility
The feature is opt-in. No breaking changes.
Screenshots