adds error message for wrong input#59
Open
bertyruan wants to merge 1 commit intozero-to-mastery:masterfrom
Open
adds error message for wrong input#59bertyruan wants to merge 1 commit intozero-to-mastery:masterfrom
bertyruan wants to merge 1 commit intozero-to-mastery:masterfrom
Conversation
bertyruan
commented
Mar 2, 2023
bertyruan
commented
- Incorrect spell input actions now updates error_message state
- UI displays error_message if it exists
- Changes the UI text from #fire-spell to #board. This fixes the incorrect CSS flex definition. The reason is CSS flex is defined on the parent property, not on children property. In this case, the board is the parent and the fire spells are the children.
- Adds an indent to the css spell properties for better UI.
🥳 Congratulations 🎉Congrats on making your first Pull Request in the Zero To Mastery Organization! ZTM Profile BadgeIf you'd like the ZTM Badge to show up on your profile, you will need to follow this guide! |
|
🙏 Thanks for your pull request @bertyruan, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated! Some of the most popular are PR Statistics
|
Author
|
@kennithnichol @beneyal @wmporter @MattCSmith please review my PR, thanks 😄 |
Author
|
@kennithnichol @beneyal @wmporter @MattCSmith could you look at my pr? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.