feat(goctl): add withCache value for deleteMethod/findOneMethod/findOneByFieldExtraMethod/insertMethod/updateMethod tpl #5351
+6
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
…neByFieldExtraMethod/insertMethod/updateMethod tpl feat(goctl): add withCache value for deleteMethod/findOneMethod/findOneByFieldExtraMethod/insertMethod/updateMethod tpl feat(goctl): add withCache value for deleteMethod/findOneMethod/findOneByFieldExtraMethod/insertMethod/updateMethod tpl
Contributor
Author
Contributor
Author
|
@kevwan can you review? |
Collaborator
|
I think custom templates are a better solution. You can customize any function name you want. |
Contributor
Author
|
When there is withCache, I can dynamically construct these functions based on whether the table has cache, and adding a withCache is also for the user to be to customize the template more flexibly. |
Contributor
Author
|
@kevwan This enhances the ability to customize templates; could you review the changes? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I want to add NoCache method for FindOne: FindOneNoCache and Nocache method for FindOneByXx: FindOneNoCacheByUsername. But interface-find-one.tpl does not render
withCachevalue, also deleteMethod/findOneMethod/findOneByFieldExtraMethod/insertMethod/updateMethod tpl need this value.interface-find-one.tpl: