Don’t require compiled Boost components; stabilize TCP-based tests#223
Open
ialexyi wants to merge 2 commits intozeromq:masterfrom
Open
Don’t require compiled Boost components; stabilize TCP-based tests#223ialexyi wants to merge 2 commits intozeromq:masterfrom
ialexyi wants to merge 2 commits intozeromq:masterfrom
Conversation
Use dynamic tcp endpoints to prevent EADDRINUSE flakiness under parallel runs. Also clarify Boost dependency is headers-only in README.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR reduces Azmq’s Boost dependency surface and makes the test suite reliable under parallel execution.
Build/packaging: switch to header-only Boost discovery (Boost::headers) and stop requiring Boost component libraries (e.g. thread/chrono/random/date_time/system).
CMake exports: update azmqConfig.cmake to use find_dependency(Boost … headers) and find_dependency(Threads) so consumers get consistent dependency resolution.
Tests: remove hard-coded TCP ports (5556/5560/9998) that caused intermittent ZeroMQ:98 Address already in use failures; bind to dynamic endpoints (tcp://127.0.0.1:*) and connect using the actual endpoint().
Tests: loosen Socket Monitor expectations to tolerate additional monitor events that can occur with dynamic binding.
Verification