Conversation
This just reduces maintenance burden. No perf tests has been done, yet. Cython is really annoying to maintain. When there are obscure errors, e.g. I have to pre-create the mem-view before passing it, which is really annoying and does not make sense. Therefore it might be useful to try and change the code to use another language.
They should be more performant and simpler to use. Still not tested the 3D unfold-copy. It requires that the 3D bloch is fully implemented, which is missing.
This should greatly speed up BZ integrations of the real-space self-energies because it skips the copying for every run, and waits until it is done. For now, it is handled internally in the respective code-paths, which is fine-enough. Enabled by default! fixed documentation
This improves the performance by a large fraction. However, it wasn't the most used code in all. Essentially it now utilizes the full Toeplitz structure.
zerothi
force-pushed
the
951-bloch-generalization
branch
from
0915efa to
4c4c327
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #952 +/- ##
=======================================
Coverage 86.90% 86.91%
=======================================
Files 412 412
Lines 54326 54333 +7
=======================================
+ Hits 47214 47221 +7
Misses 7112 7112 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
docs/changes/<pr-num>.<type>.rst