Fix plots bug due to new pandas casting#983
Merged
zerothi merged 3 commits intozerothi:mainfrom Mar 13, 2026
Merged
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| value = dic[key] | ||
| try: | ||
| dic[key] = value.where(value.notnull(), other=None) | ||
| except: |
Check notice
Code scanning / CodeQL
Empty except Note
| value = dic[key] | ||
| try: | ||
| dic[key] = value.where(value.notnull(), other=None) | ||
| except: |
Check notice
Code scanning / CodeQL
Except block handles 'BaseException' Note
Owner
|
Thanks, fixed! |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #983 +/- ##
=======================================
Coverage 86.66% 86.67%
=======================================
Files 413 413
Lines 54373 54388 +15
=======================================
+ Hits 47125 47140 +15
Misses 7248 7248 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pandas has new rules for inferring types: https://pandas.pydata.org/docs/user_guide/migration-3-strings.html
This was making plots fail because
Nonewas suddenly parsed toNaNwhich in some cases was not accepted by the plotting routines.