Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting from MacOS Tahoe, running ZeroTierOne may corrupt the operating system’s routing table and DNS configuration (#2520 ). The occurrence of this problem depends on the network environment (not happen in all environments). In certain network setups, when
Allow Managed Addressesis enabled, either immediately or after running for a period of time, the OS routing table and DNS become unusable. In the past three months (after updating to MacOS Tahoe), I have to disableAllow Managed Addressesand manually add the virtual IP bysudo ifconfig feth537 inet xx.xx.xx.xx/24 up.These days, by debugging, I found that this issue is related to the code in
MacDNSHelper.mm. As shown in the code, skipping the configuration ofState:/Network/Service/%.16llx/IPv4:RouterinSystemConfigurationcan prevent this problem from occurring.The logic of the setting was introduced in commit #1d095e8, seemingly to fix network DNS on macOS. However, starting with MacOS Tahoe, Apple appears to have changed certain behaviors related to
SystemConfiguration, causing the breaking.Here is my environment:
In my network environment, applying the modification of this PR restores normal behavior. However, I am not sure whether this change could introduce other issues, for example when the settings of
allowGlobal/allowDefault/allowDNSchanges.I would appreciate if maintainers or others who can build and test ZeroTier could help verify this PR.