Limite dans le formulaire la longueur du commentaire pour l'ajout d'un contributeur#6779
Open
philippemilink wants to merge 2 commits intozestedesavoir:devfrom
Open
Limite dans le formulaire la longueur du commentaire pour l'ajout d'un contributeur#6779philippemilink wants to merge 2 commits intozestedesavoir:devfrom
philippemilink wants to merge 2 commits intozestedesavoir:devfrom
Conversation
philippemilink
force-pushed
the
add-contributor-comment-limit
branch
from
1f9e060 to
7ead0ee
Compare
Arnaud-D
reviewed
Feb 2, 2026
zds/tutorialv2/tests/__init__.py
Outdated
Comment on lines
34
to
35
| for msg in msgs: | ||
| last = msg |
Contributor
There was a problem hiding this comment.
On ne peut pas faire quelque chose du genre msgs[-1] ici ?
Member
Author
There was a problem hiding this comment.
En effet, en forçant un peu il est possible d'éviter la boucle. J'ai corrigé le commit.
philippemilink
force-pushed
the
add-contributor-comment-limit
branch
from
7ead0ee to
959d9e7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug rapporté par Sentry : le formulaire pour ajouter un contributeur à un contenu ne vérifie pas la longueur maximale possible du commentaire et c'est MariaDB qui provoque une exception lors de la sauvegarde en base de données. En local, il n'est pas possible de reproduire le bug puisque SQLite ne vérifie pas les limites de longueurs dans les colonnes.
Cette PR ajoute la limite de la longueur dans le formulaire correspondant et ajoute un test.
Contrôle qualité
La CI passe.
adminLes deux commits sont indépendants, on peut donc éviter le squash lors de la fusion.