Open
Conversation
Contributor
|
How about we dont break backwards compatibility by simply adding ANOTHER implementation of Cache as opposed to changing it. So file cache would work with both Path and &Path and we can just merge it right now |
zesterer
force-pushed
the
main
branch
2 times, most recently
from
2f36bc2 to
4b3807c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As reported in #40,
FileCacheisn't usable, as it only implementsCache<Path>. However, asPathis unsized, it's impossible to actually pass in aPath, makingFileCacheunusable. This PR just changes the implementation to use&Pathinstead. In my quick testing, it appears to now work without any issues.