Implementing Char for graphemes and all the necessary changes to make it happen.#698
Merged
zesterer merged 14 commits intozesterer:mainfrom Jan 1, 2025
Merged
Conversation
add `Grapheme`, `Graphemes` and `GraphemeIter` types move the implementation of input traits to the `text` module replace type `Input::Item` with `Grapheme` implement seq traits for graphemes
Remove `Char::Str` and everything related to it. Remove a number of supertraits for the `Char` trait. Replace `Char::to_char()` with `Char::to_ascii()`. Remove `Char::from_ascii()`. Add `Char::is_newline()`. Remove the generic `C` from `StrInput`.
Owner
|
Thanks! I'll try to find time to review this over the next day or two. |
Replace their uses with references to them.
in `src/text.rs:609:10`
zesterer
approved these changes
Jan 1, 2025
Owner
zesterer
left a comment
zesterer
left a comment
There was a problem hiding this comment.
Happy with these changes, thanks for your work on this PR!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added
GraphemesandGraphemetypes. Cardinally updatedChartrait and slightly modifiedStrInputtrait