This repository was archived by the owner on Apr 2, 2026. It is now read-only.
build!: remove unused spin and feature flag#938
Merged
zesterer merged 2 commits intozesterer:mainfrom Jan 3, 2026
Merged
Conversation
Signed-off-by: tison <wander4096@gmail.com>
tisonkun
force-pushed
the
remove-unused-deps
branch
from
1f88756 to
f3f1f5a
Compare
Contributor
Author
|
I'd first seek a consensus on removing this. And if it is desired, please tell me how to fix the semver failure. I don't use that tool before. |
Owner
|
Thanks! #889 is due to remove the feature anyway, but I'm happy to see this merged too. You'll need to bump the crate version for CI to pass. |
Signed-off-by: tison <wander4096@gmail.com>
Contributor
Author
|
@zesterer Thanks for your feedback! Bumped to 0.13.0 and hopefully this is correct :D |
Owner
|
Thanks :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cc @zesterer seems no longer depending on it.