Conversation
meshopt_quantizeHalf/Float were initially inline C++ functions but were later converted to proper functions in quantization.cpp; however, they were still in the "inline C++" block that was not under extern "C". This makes it harder to access these functions via FFI, so this change moves them into extern "C" block which changes the function mangling to C. meshopt_quantizeUnorm/Snorm remain inline; this is necessary both for performance, as inlining them with a constant N produces much more efficient code, and because they are used in some meshopt algorithm implementations, and by convention every translation unit in meshoptimizer library must be self-contained for ease of compilation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
meshopt_quantizeHalf/Floatwere initially inline C++ functions but were later converted to proper functions inquantization.cpp; however, they were still in the "inline C++" block that was not underextern "C". This makes it harder to access these functions via FFI, so this change moves them, as well asmeshopt_dequantizeHalf, intoextern "C"block which changes the function mangling to C.meshopt_quantizeUnorm/Snormremain inline; this is necessary both for performance, as inlining them with a constantNproduces much more efficient code, and because they are used in some meshopt algorithm implementations, and by convention every translation unit in meshoptimizer library must be self-contained for ease of compilation.See #838.