Fix misaligned memory access in UTF-16/UTF-32 buffer conversion#699
Open
MarkLee131 wants to merge 1 commit intozeux:masterfrom
Open
Fix misaligned memory access in UTF-16/UTF-32 buffer conversion#699MarkLee131 wants to merge 1 commit intozeux:masterfrom
MarkLee131 wants to merge 1 commit intozeux:masterfrom
Conversation
convert_buffer_generic() casts the input void* directly to uint16_t*/uint32_t* without checking alignment. When the buffer is not naturally aligned, this is undefined behavior and crashes on strict-alignment architectures (e.g. SIGBUS on some ARM configs). Fix by copying to an aligned temporary buffer when misalignment is detected. The copy only happens for misaligned inputs, so there is no overhead in the common case. Uses the existing auto_deleter RAII pattern already used elsewhere in the codebase. Similar to the SPARC64 alignment fix in v1.7 (commit bd7a8fa).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #698:
convert_buffer_generic() casts the input void* directly to uint16_t*/uint32_t* without checking alignment. When the buffer is not naturally aligned, this is undefined behavior and crashes on strict-alignment architectures (e.g. SIGBUS on some ARM configs).
Fix by copying to an aligned temporary buffer when misalignment is detected. The copy only happens for misaligned inputs, so there is no overhead in the common case. Uses the existing auto_deleter RAII pattern already used elsewhere in the codebase.
Similar to the SPARC64 alignment fix in v1.7 (commit bd7a8fa).