Accept on and off as well as true and false in zfs command outputs#115
Open
bluecube wants to merge 1 commit intozfsonlinux:masterfrom
Open
Accept on and off as well as true and false in zfs command outputs#115bluecube wants to merge 1 commit intozfsonlinux:masterfrom
bluecube wants to merge 1 commit intozfsonlinux:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Today i noticed that zfs-auto-snapshot has not been snapshoting my filesystems for three months now.
After some digging I found out that the zfs command outputs "on" and "off" as values of boolean properties, but zfs-auto-snapshot only accepts "true" and "false".
This pull request modifies the script to accept both formats.
I didn't check why or when the output format was changed ...