Skip to content

[fix] fixed error "using Float as a String" when system locale using comma as float separator#25

Open
TKr wants to merge 2 commits intozhaocai:masterfrom
TKr:master
Open

[fix] fixed error "using Float as a String" when system locale using comma as float separator#25
TKr wants to merge 2 commits intozhaocai:masterfrom
TKr:master

Conversation

@TKr
Copy link

@TKr TKr commented Feb 4, 2016

Mac OSX, phpstorm terminal vs system terminal

When LC_NUMERIC="C"
let s:goldenview__golden_ratio = 1.618
end with error using Float as a String

When i set LC_NUMERIC="pl_PL.UTF-8"
let s:goldenview__golden_ratio = 1.618
without problem.

After fix:
When LC_NUMERIC="C"
let l:golden_ratio_dot = str2float("1.618") /// 1
let l:golden_ratio_comma = str2float("1,618") /// 1,618
When LC_NUMERIC="pl_PL.UTF-8"
let l:golden_ratio_dot = str2float("1.618") /// 1.618
let l:golden_ratio_comma = str2float("1,618") /// 1

Then
let s:goldenview__golden_ratio = l:golden_ratio_xxxx
and both without errors.

@ReneFroger
Copy link

Please try golden-ratio on Emacs instead.

@dgilge
Copy link

dgilge commented Jan 23, 2018

Same issue here.

E806: using Float as a String
E15: Invalid expression: 1.618

Are there plans to fix this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants