Skip to content

if there is no feedback on suggest, search on google anyways #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
durandom wants to merge 2 commits into
base: master
Choose a base branch
from
Open

if there is no feedback on suggest, search on google anyways #6

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c8ac7d9
if there is no feedback on suggest, search on google anyways
durandom Mar 13, 2014
f0e720f
detect character encoding of google result
durandom Mar 13, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions google/lib/google_suggest.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,12 @@ def suggest_for(keyword)
:q => URI.encode(keyword)}
res = http_get('/complete/search', query)

doc = REXML::Document.new(res.body.to_s)
result_body = if res['content-type'] =~ /iso-8859-1/i
res.body.to_s.force_encoding("ISO-8859-1").encode("UTF-8")
else
res.body.to_s
end
doc = REXML::Document.new(result_body)

suggestions = []
doc.elements.each("toplevel/CompleteSuggestion/suggestion") { |elem |
Expand All @@ -61,15 +66,15 @@ def suggest_for(keyword)

def http
if @proxy
proxy_url = URI.parse(@proxy)
proxy_url = URI.parse(@proxy)
http_class = Net::HTTP.Proxy(proxy_url.host, proxy_url.port)
else
http_class = Net::HTTP
end
http_class.new(GOOGLE_HOST)
end

def http_get(path, query)
def http_get(path, query)
path = path + '?' + query.map{|k,v| "#{k}=#{v}"}.join('&')
req = Net::HTTP::Get.new(path)
http.request(req)
Expand Down
11 changes: 11 additions & 0 deletions google/suggest.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,17 @@ def generate_feedback(alfred, query)

end

if feedback.items.length == 0
feedback.add_item({
:title => query ,
:subtitle => "Search Google for #{query}" ,
:arg => query ,
:autocomplete => query ,
:icon => icon ,
})
end


puts feedback.to_xml
end

Expand Down