Improved Matplotlib version checking for Python code#50
Open
pixalytics wants to merge 1 commit intozhaokg:masterfrom
Open
Improved Matplotlib version checking for Python code#50pixalytics wants to merge 1 commit intozhaokg:masterfrom
pixalytics wants to merge 1 commit intozhaokg:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm installing Rbeast with Python 3.12 and Matplotlib 3.10.1, and the logic for checking the Matplotlib version is failing. As a result, the plotting code tries to incorrectly use the "use_line_collection=True" option that no longer exists. So, I'd like to suggest an improved approach for version checking and I've also created consistency for the three lines where the version is checked. Sam