Retrieval Support Dev #30
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
...nstrumentation-langchain-dev/src/opentelemetry/instrumentation/langchain/callback_handler.py
Show resolved
Hide resolved
util/opentelemetry-util-genai-dev/src/opentelemetry/util/genai/emitters/metrics.py
Show resolved
Hide resolved
...emetry-instrumentation-langchain-dev/src/opentelemetry/instrumentation/langchain/__init__.py
Show resolved
Hide resolved
JWinermaSplunk
commented
Oct 14, 2025
| self._telemetry_handler = handler | ||
| self._entities: dict[UUID, GenAI] = {} | ||
| self._llms: dict[UUID, UtilLLMInvocation] = {} | ||
| self._retrievals: dict[UUID, UtilRetrievalInvocation] = {} |
Collaborator
Author
There was a problem hiding this comment.
wondering if storing retrieval calls like this is necessary with this iteration?
adityamehra
reviewed
Oct 15, 2025
...emetry-instrumentation-langchain-dev/src/opentelemetry/instrumentation/langchain/__init__.py
Outdated
Show resolved
Hide resolved
util/opentelemetry-util-genai-dev/src/opentelemetry/util/genai/attributes.py
Show resolved
Hide resolved
util/opentelemetry-util-genai-dev/src/opentelemetry/util/genai/attributes.py
Show resolved
Hide resolved
util/opentelemetry-util-genai-dev/src/opentelemetry/util/genai/attributes.py
Show resolved
Hide resolved
util/opentelemetry-util-genai-dev/src/opentelemetry/util/genai/emitters/metrics.py
Show resolved
Hide resolved
util/opentelemetry-util-genai-dev/src/opentelemetry/util/genai/emitters/span.py
Show resolved
Hide resolved
Collaborator
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add retrieval span support to dev.
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.