Changed tests to use firmware_feature_enabled() methods #2052
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andy-maier
force-pushed
the
andy/fix-feature-enabled
branch
from
8467dea to
5642ba2
Compare
andy-maier
force-pushed
the
andy/fix-feature-enabled
branch
2 times, most recently
from
a335fbb to
a26cf3b
Compare
Details: * In tests/unit/zhmcclient/test_cpc/partition.py, disabled the DeprecationWarning for using the deprecated Cpc/Partition.feature_enabled() in test function test_cpc/partition_feature_enabled(). That function intentionally tests the deprecated method. * In tests/end2end/test_cpc/partition.py, removed the tests of the deprecated Cpc/Partition.feature_enabled() methods in test functions test_cpc/partition_features(). * In tests/end2end/utils.py, changed the skipif_no_storage_mgmt_feature() and skipif_storage_mgmt_feature() functions to use the Cpc.firmware_feature_enabled() method instead of the deprecated Cpc.feature_enabled() method. Signed-off-by: Andreas Maier <[email protected]>
andy-maier
force-pushed
the
andy/fix-feature-enabled
branch
from
a26cf3b to
3e20550
Compare
Collaborator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For details, see the commit message.