pattern-gen: introduce behavior AST scaffolding for frontend/backend split#2
Open
zhouguangyuan0718 wants to merge 1 commit intollvm-20.1.0from
Open
pattern-gen: introduce behavior AST scaffolding for frontend/backend split#2zhouguangyuan0718 wants to merge 1 commit intollvm-20.1.0from
zhouguangyuan0718 wants to merge 1 commit intollvm-20.1.0from
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Behaviorhandling.Description
BehaviorExpressionandBehaviorStatementstructs to model expression kinds (Generic,Assignment,Index) and statement kinds (Scope,If,While,For,Declaration,Expr).classify_expression(...)which runs the existingParseExpressionpipeline and then heuristically classifies the parsed source slice (looking for[or assignment=vs==) into expression kinds.ParseDeclaration,ParseStatement, andParseScope(added optionalBehaviorStatement *astparameter) so parsing can populate a lightweight AST while continuing to emit LLVM IR via the current code paths.ParseBehaviourcreate a top-levelBehaviorStatement behaviorASTand invokeParseStatement(..., &behaviorAST), thereby constructing the new frontend representation without changing the current lowering that follows.Testing
llvm/tools/pattern-gen/lib/Parser.cppand inspected the resulting diff withgit diff, confirming the structural changes were introduced as intended.git -C /workspace/CoreDSL2LLVM commit ...and the commit succeeded.Codex Task