-
-
Notifications
You must be signed in to change notification settings - Fork 184
text slide #244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
text slide #244
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
WalkthroughThis update enhances the user interface by introducing new animations and improving code readability. The changes include the addition of a Changes
TipsChat with CodeRabbit Bot (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 1
Files selected for processing (2)
- frontend/src/components/organisms/TemplateCard/index.js (4 hunks)
- frontend/src/util/animation/index.js (2 hunks)
Files skipped from review due to trivial changes (1)
- frontend/src/util/animation/index.js
Additional comments (Suppressed): 2
frontend/src/components/organisms/TemplateCard/index.js (2)
57-61: The new
useStylesfunction creates a CSS class with animation, which is then applied to theTextFieldcomponent. This enhances the user interface by adding an animation effect to the text field.92-95: The
TextFieldcomponent now has a new CSS classtextFieldWithAnimationapplied to it. This class adds an animation effect to the text field when it is rendered.
| Slide, | ||
| CircularProgress, | ||
| } from "@material-ui/core"; | ||
| import { makeStyles } from "@material-ui/core/styles"; | ||
| import getTemplate from "../../../util/template/getTemplate"; | ||
| import Template from "../../../util/template/Template"; | ||
| import mainLayouts from "../../../util/layouts"; | ||
| import mainAnimations from "../../../util/animation"; | ||
| import mainThemes from "../../../util/themes"; | ||
| import mainFonts from "../../../util/fonts"; | ||
| import animations from "../../../util/animation"; | ||
|
|
||
| const TemplateCard = (props) => { | ||
| const [showSnackbar, setShowSnackbar] = useState(false); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The import statement for animations from "../../../util/animation" is duplicated. The animations are already imported as mainAnimations on line 15. You should remove the duplicate import.
- import animations from "../../../util/animation";
zhravan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing work @Felobateer :D
Thank you for your amazing contribution!! Really appreciate your efforts and time taken to contribute :)
Can you address the PR comment provided by coderabbitai?
|
@Felobateer Are you still working on this? |
Hey @Shravan20 I added a new animation to the index.js file in the animation folder in Utils and connected it to the text field.
I never worked with material ui before so I hope I did a good job.
Summary by CodeRabbit
TextFieldcomponent inTemplateCard, enhancing user interaction and visual appeal.grow_out_inanimation within theanimationsobject, ensuring smooth and accurate animations.animationsobject by refining indentation and formatting. Added a new"slide-text"animation for future use.