fix(electron): save AlwaysOnTop preferences to avoid setting insconsistencies#601
fix(electron): save AlwaysOnTop preferences to avoid setting insconsistencies#601dubisdev wants to merge 1 commit intozidoro:masterfrom
Conversation
|
Ill try to test after work today or tomorrow and see if I can reproduce this and if it effects the tauri version, see if the always on top is triggering and if not why though I already assume you've done this. I just wanted to check that this isn't an issue that's somehow not effecting tauri but is effecting electron or if it need a common fix. |
|
I checked both Tauri and Electron connectors in the renderer app. Both are using the useEffect to inform the backend of this setting on app start. Anyway, take a look in case I missed something :) |
|
Sorry haven't had a chance to test this yet given the nature of wanting to test the startup behaviour needing to reboot. Code looks fine though I'll perform a local test first. |
|
Noticed the latest version release on Tauri has the issue on restart too on windows at least. This probably needs a frontend change to emit these settings on ready though this may be a good idea too. |
|
Yeah! The problem I see here is that we are already doing that 😟 Both connectors emmit the event on the app load so this should be working. pomatez/app/renderer/src/contexts/connectors/TauriConnector.tsx Lines 142 to 146 in d802264 pomatez/app/renderer/src/contexts/connectors/ElectronConnector.tsx Lines 69 to 73 in d802264 BTW I cannot reproduce this (I'm using windows and all is working well for me) |
re https://discord.com/channels/1173649313734328441/1201478264112296046