Change ImGui's SDL2-OpenGL-backend loader to upstream's own one #24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Sounds good to me. This has been a pain before and I don't see any reason not to use the upstream loader. |
ckrowland
pushed a commit
to ckrowland/zgui
that referenced
this pull request
Jul 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've had unsolvable issues getting the current version's SDL2/OpenGL backend to work. In its current state - at least on my machine - the ImGui lib seems to both require static OpenGL symbols but at the same time use its own dynamic ones, so even when I link GL, ImGui crashes on init trying to call
glGetString, which seems to be an invalid pointer, while I myself can callglGetStringjust fine.So I would propose changing it to ImGui's own private loader to make it independent of a user's way to get GL.