This repository was archived by the owner on Nov 25, 2025. It is now read-only.
Switch to using target triple like prefix for installed exes#429
Closed
Switch to using target triple like prefix for installed exes#429
Conversation
|
I think this should fix Thanks for the quick fix! |
Techatrix
reviewed
May 25, 2025
Comment on lines
+291
to
+298
| } else if (name.startsWith(prefixOld)) { | ||
| const version = name.substring(prefixOld.length + 1); | ||
| await vscode.workspace.fs.rename( | ||
| vscode.Uri.joinPath(storageDir, name), | ||
| vscode.Uri.joinPath(storageDir, `${prefix}-${version}`), | ||
| ); | ||
| await setLastAccessTime(config, new semver.SemVer(version)); | ||
| available.push(new semver.SemVer(version)); |
Collaborator
There was a problem hiding this comment.
This converts all installed Zig and ZLS versions from $OS-$Arch-$Version to $Arch-$OS-$Version but this isn't how installGuarded will try to look them up. It still expects the old format for ZLS and older Zig versions.
| const fileExtension = isWindows ? "zip" : "tar.xz"; | ||
| const exeName = config.exeName + (isWindows ? ".exe" : ""); | ||
| const subDirName = `${getZigOSName()}-${getZigArchName()}-${version.raw}`; | ||
| const subDirName = `${getHostZigName()}-${version.raw}`; |
Collaborator
There was a problem hiding this comment.
This will fail for older Zig versions like 0.13.0. subDirName is also used to resolve the file name that should be downloaded.
Collaborator
|
I tried to resolve these issues myself and ended up with #430 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ziglang/zig#23977 (comment)