std.math.big: require sufficient capacity for aliased params#26019
Closed
aaron-ang wants to merge 1 commit intoziglang:masterfrom
Closed
std.math.big: require sufficient capacity for aliased params#26019aaron-ang wants to merge 1 commit intoziglang:masterfrom
aaron-ang wants to merge 1 commit intoziglang:masterfrom
Conversation
aaron-ang
force-pushed
the
bigint-uaf
branch
2 times, most recently
from
deb84da to
c8011c6
Compare
Author
|
hi @andrewrk could you trigger the CI? |
aaron-ang
force-pushed
the
bigint-uaf
branch
from
c8011c6 to
cfeda3c
Compare
Member
|
Closing because we have no CI on GitHub anymore and this has no CI results. Please reopen this on Codeberg: https://codeberg.org/ziglang/zig/pulls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
close #6167
We first check if the
Managedinstances are distinct but share the samelimbsfield inlimbsAliasDistinct.We then assert in
ensureAliasAwareCapacitythat an aliasedManagedparameter has enough capacity such that it will not trigger a reallocation. This should prevent use-after-free.Identical
Managedinstances should not result in use-after-free sincetoConstis called after any reallocation is done, so the underlying instances should point to the same limbs buffer during the actual arithmetic operation.