Add Tuya PC321-Z-TY 3 phase power meter #3644

abmantis · 2024-12-25T23:47:20Z

Proposed change

Device in Z2M: https://www.zigbee2mqtt.io/devices/TS0601_3_phase_clamp_meter.html

Additional information

Requires: #3643

Checklist

The changes are tested and work correctly
pre-commit checks pass / the code has been formatted using Black
Tests have been added to verify that the new code works

codecov · 2024-12-25T23:48:50Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.06%. Comparing base (62765a4) to head (687dbe8).
Report is 6 commits behind head on dev.

Additional details and impacted files

@@            Coverage Diff             @@
##              dev    #3644      +/-   ##
==========================================
+ Coverage   91.00%   91.06%   +0.05%     
==========================================
  Files         328      332       +4     
  Lines       10656    10723      +67     
==========================================
+ Hits         9698     9765      +67     
  Misses        958      958

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

…1_TZE200_nslr42tt

…multi_attr

jeverley · 2025-02-04T12:03:16Z

@abmantis, @prairiesnpr I've been working on a v2 quirk specifically for supporting multiple Tuya energy meter devices (#3824) - it already has mappings for 4 devices.

It would be pretty straightforward to support this device in that quirk by adding the relevant datapoints, I'll add those in this evening if you're happy to go that route (I'm conscious we want to avoid duplication of effort & code).

Tagging #3764 too for visibility.

abmantis · 2025-02-06T00:11:34Z

@jeverley Thanks for the suggestion, but I don't think this device would benefit from that.

As far as I know, this device only measures current in one direction, so no need for direction calculation/mitigation.
Also, I am not sure we should have virtual channels, as those can be added by the users on HA side, if they want to. That would add extra complexity to the quirks, making it harder for people to contribute to them.

Personally, given the added complexity, I would prefer to keep it simple unless there is something it is really missing.

…multi_attr

jeverley · 2025-02-07T10:45:06Z

@jeverley Thanks for the suggestion, but I don't think this device would benefit from that.

As far as I know, this device only measures current in one direction, so no need for direction calculation/mitigation. Also, I am not sure we should have virtual channels, as those can be added by the users on HA side, if they want to. That would add extra complexity to the quirks, making it harder for people to contribute to them.

Personally, given the added complexity, I would prefer to keep it simple unless there is something it is really missing.

I was aiming to create a single file in which we could maintain Tuya energy meter devices consistently (utilising native zigbee clusters rather than custom sensors - this comes with the benefit of translations being available out of the box for the entities).
The intent being it would keep things easier to maintain than having per device implementations scattered accross multiple files.

The POC b566139 commit excludes this device from the virtual channel + directionality logic (this is optionally be used for a device if required).

I suppose an alternative approach might be to split my PR into two files, one with 'simple' energy meter devices which don't require the energy direction logic to sign values, and those that do.

…lers into TS0601_TZE200_nslr42tt

abmantis · 2025-02-08T00:44:14Z

I was aiming to create a single file in which we could maintain Tuya energy meter devices consistently (utilising native zigbee clusters rather than custom sensors - this comes with the benefit of translations being available out of the box for the entities). The intent being it would keep things easier to maintain than having per device implementations scattered accross multiple files.

The POC b566139 commit excludes this device from the virtual channel + directionality logic (this is optionally be used for a device if required).

I suppose an alternative approach might be to split my PR into two files, one with 'simple' energy meter devices which don't require the energy direction logic to sign values, and those that do.

I just updated this PR because it had a lot of outdated stuff from the multi_dp branch. You can see from https://github.com/zigpy/zha-device-handlers/pull/3644/files#diff-5da7f6ba0921c69699fbf6b68fb97058fef0d107cbb4193173309e0894833f05 that it doesn't have much that could be reused by other quirks.

Regarding using standard zigbee attributes, I tried to do it for most attributes, except for energy since there is no 3 phase energy stuff in the standard. I tried using different endpoints, but ended up going for custom tuya attributes (I don't remember why I decided on that, maybe because of the naming?). I'll check that again before moving this to ready just to be sure.

Personally, I prefer to keep the PRs as small as possible instead of bundling multiple changes in one big PR. So I would add this one as a simple quirk, and then add shared stuff later, as a different PR.
But I'll leave that for the maintainers to decide, as I am also ok with doing it all in one big PR if that is preferred.

rhakbari · 2025-02-15T09:08:09Z

Support for Tuya Zemismart 3 Phase Power Meter _TZE200_v9hkz2yn variant needs to be added as I tested your current quirk and it is not working with the Zemismart 3 phase device. Kindly check this PR [https://github.com//pull/3764] in which I have worked on. This custom quirk is working but it is on v1 quirk and the PR wasn't merged due to the versioning.

abmantis · 2025-02-15T14:53:04Z

Support for Tuya Zemismart 3 Phase Power Meter _TZE200_v9hkz2yn variant needs to be added as I tested your current quirk and it is not working with the Zemismart 3 phase device.

That does not seem to be the same device as the one in this PR. Are the data points the same?

rhakbari · 2025-02-15T16:24:51Z

Support for Tuya Zemismart 3 Phase Power Meter _TZE200_v9hkz2yn variant needs to be added as I tested your current quirk and it is not working with the Zemismart 3 phase device.

That does not seem to be the same device as the one in this PR. Are the data points the same?

Yeah, it's not the same device as in your PR, which is why we would need to add it to the PR with v2 quirks. My PR was created using v1 quirks since I wasn't aware of v2 at the time.

abmantis · 2025-02-16T00:00:26Z

Support for Tuya Zemismart 3 Phase Power Meter _TZE200_v9hkz2yn variant needs to be added as I tested your current quirk and it is not working with the Zemismart 3 phase device.

That does not seem to be the same device as the one in this PR. Are the data points the same?

Yeah, it's not the same device as in your PR, which is why we would need to add it to the PR with v2 quirks. My PR was created using v1 quirks since I wasn't aware of v2 at the time.

In that case it should be on a new separate PR, not on this one (except it shares the same endpoints and has just a different model id)

…to TS0601_TZE200_nslr42tt

zhaquirks/tuya/ts0601_power.py

TheJulianJES

Ok, one small (hopefully) last thing. Looks good otherwise.

zhaquirks/tuya/ts0601_power.py

TheJulianJES

Thanks!

TheJulianJES · 2025-03-25T23:22:55Z

zhaquirks/tuya/ts0601_power.py

+    .removes(LevelControl.cluster_id)
+    .removes(OnOff.cluster_id)


Not sure if these clusters have any use at all, but we can now use prevent_default_entity_creation(endpoint_id=1, cluster_id=OnOff.cluster_id) as well (instead of completely "removing" the clusters).

They did not seem to do anything at all. Should prevent_default_entity_creation be used instead for these cases?

TheJulianJES · 2025-03-25T23:24:35Z

zhaquirks/tuya/ts0601_power.py

+    .tuya_sensor(
+        dp_id=134,
+        attribute_name="device_status",
+        type=t.int32s,
+        fallback_name="Device status",
+        translation_key="device_status",
+    )


What does this sensor show? Since it's only numerical..

I have no ideia, I just added it since it is also on Z2M :/ On mine it is always 0.
Should I remove it?

abmantis added 3 commits December 25, 2024 23:08

Add support for Tuya DPs mapped to multiple cluster attributes

f22ee00

Add test

0cf12e5

Add Tuya PC321-Z-TY 3 phase power meter

2b63c35

TheJulianJES added Tuya Request/PR regarding a Tuya device needs review This PR should be reviewed soon, as it generally looks good. labels Dec 26, 2024

abmantis and others added 5 commits January 2, 2025 15:51

Merge branch 'dev' into tuya_multi_attr

d36c1c2

Merge branch 'dev' of github.com:zigpy/zha-device-handlers into TS060…

af12ce4

…1_TZE200_nslr42tt

Merge branch 'dev' of github.com:zigpy/zha-device-handlers into tuya_…

98ff595

…multi_attr

Make dp_to_attribute backwards compatible

32c3fbb

Merge branch 'dev' of github.com:zigpy/zha-device-handlers into tuya_…

47bd335

…multi_attr

prairiesnpr mentioned this pull request Jan 23, 2025

Added Support for Tuya Zemismart 3 Phase Power Meter _TZE200_v9hkz2yn variant #3764

Closed

3 tasks

abmantis added 2 commits January 31, 2025 22:40

Merge branch 'dev' of github.com:zigpy/zha-device-handlers into tuya_…

6142170

…multi_attr

Move _dp_to_attributes to init; add tests

965a3ac

abmantis added 2 commits February 6, 2025 22:13

Merge branch 'dev' of github.com:zigpy/zha-device-handlers into tuya_…

5d58046

…multi_attr

Call tuya_dp_multi on tuya_dp to avoid duplicating

581bc0f

abmantis added 2 commits February 8, 2025 00:17

Merge branch 'tuya_multi_attr' of github.com:abmantis/zha-device-hand…

08eab65

…lers into TS0601_TZE200_nslr42tt

Remove uneeded constant attrs

3792e0d

abmantis added 2 commits February 23, 2025 15:13

Merge branch 'dev' of https://github.com/zigpy/zha-device-handlers in…

2c09161

…to TS0601_TZE200_nslr42tt

Add final tweaks and fixes

8700364

abmantis marked this pull request as ready for review February 23, 2025 16:38

TheJulianJES reviewed Feb 26, 2025

View reviewed changes

zhaquirks/tuya/ts0601_power.py Outdated Show resolved Hide resolved

zhaquirks/tuya/ts0601_power.py Show resolved Hide resolved

TheJulianJES added the smash This PR is close to be merged soon label Feb 26, 2025

Add tests for multi_dp converters; fix casing

0ad7fad

abmantis requested a review from TheJulianJES February 26, 2025 14:59

abmantis added 2 commits March 7, 2025 23:22

Merge branch 'dev' into TS0601_TZE200_nslr42tt

c93a045

Merge branch 'dev' into TS0601_TZE200_nslr42tt

99f3b52

abmantis mentioned this pull request Mar 19, 2025

Add support for 3 phase power energy meter TS0601 _TZE284_dikb3dp6 #3956

Closed

3 tasks

abmantis marked this pull request as draft March 19, 2025 12:21

Add missing negative power tests

b0e7a9c

abmantis marked this pull request as ready for review March 19, 2025 16:50

TheJulianJES reviewed Mar 22, 2025

View reviewed changes

zhaquirks/tuya/ts0601_power.py Outdated Show resolved Hide resolved

Use decimal DPs

a8c3034

abmantis requested a review from TheJulianJES March 25, 2025 15:54

abmantis marked this pull request as draft March 25, 2025 15:56

Revert old method names

687dbe8

abmantis marked this pull request as ready for review March 25, 2025 15:59

TheJulianJES approved these changes Mar 25, 2025

View reviewed changes

TheJulianJES merged commit 4c8875e into zigpy:dev Mar 25, 2025
9 checks passed

cdce8p mentioned this pull request Jun 10, 2025

Replace ByteString #4119

Merged

3 tasks

Add Tuya PC321-Z-TY 3 phase power meter #3644

Add Tuya PC321-Z-TY 3 phase power meter #3644

Uh oh!

Conversation

abmantis commented Dec 25, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Proposed change

Additional information

Checklist

Uh oh!

codecov bot commented Dec 25, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

jeverley commented Feb 4, 2025

Uh oh!

abmantis commented Feb 6, 2025

Uh oh!

jeverley commented Feb 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

abmantis commented Feb 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rhakbari commented Feb 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

abmantis commented Feb 15, 2025

Uh oh!

rhakbari commented Feb 15, 2025

Uh oh!

abmantis commented Feb 16, 2025

Uh oh!

Uh oh!

Uh oh!

TheJulianJES left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

TheJulianJES left a comment

Choose a reason for hiding this comment

Uh oh!

TheJulianJES Mar 25, 2025

Choose a reason for hiding this comment

Uh oh!

abmantis Mar 27, 2025

Choose a reason for hiding this comment

Uh oh!

TheJulianJES Mar 25, 2025

Choose a reason for hiding this comment

Uh oh!

abmantis Mar 27, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

abmantis commented Dec 25, 2024 •

edited

Loading

codecov bot commented Dec 25, 2024 •

edited

Loading

jeverley commented Feb 7, 2025 •

edited

Loading

abmantis commented Feb 8, 2025 •

edited

Loading

rhakbari commented Feb 15, 2025 •

edited

Loading