Skip to content

Conversation

rhakbari
Copy link
Contributor

@rhakbari rhakbari commented Jan 23, 2025

@rhakbari
Copy link
Contributor Author

@TheJulianJES Please merge this PR so that support for this device can be pushed in the next release of ZHA. Thanks

Copy link

codecov bot commented Jan 23, 2025

Codecov Report

Attention: Patch coverage is 72.83951% with 22 lines in your changes missing coverage. Please review.

Project coverage is 90.19%. Comparing base (4f64c18) to head (37fc327).
Report is 63 commits behind head on dev.

Files with missing lines Patch % Lines
zhaquirks/tuya/ts0601_din_power.py 72.83% 22 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #3764      +/-   ##
==========================================
+ Coverage   90.13%   90.19%   +0.05%     
==========================================
  Files         320      320              
  Lines       10473    10554      +81     
==========================================
+ Hits         9440     9519      +79     
- Misses       1033     1035       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@prairiesnpr
Copy link
Collaborator

@rhakbari Thanks for the PR, we have been putting a lot of effort into transitioning the Tuya codebase to use v2 quirks. I really don't want to see us merge another v1 PR that would need to be updated later on. We don't currently have an example of a v2 power meter quirk merged, but you could look at either #3644 or #3571 to get an idea of where we are headed. Once we merge one of them, you would have a good example to draw from.

@rhakbari
Copy link
Contributor Author

@prairiesnpr Is there some kind of documentation for the quirk v2 library etc that can show some kind of comparison so that I can go through and see what functions i can use from it?

@prairiesnpr
Copy link
Collaborator

@prairiesnpr Is there some kind of documentation for the quirk v2 library etc that can show some kind of comparison so that I can go through and see what functions i can use from it?

https://github.com/zigpy/zha-device-handlers/blob/dev/tuya.md and https://github.com/zigpy/zha-device-handlers/wiki/Tuya-%E2%80%90-v2-Quirk-with-TuyaQuirkBuilder would be a good start.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants