Add Telink devices with custom ZigbeeTlc firmware quirk
#3719
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #3719 +/- ##
==========================================
+ Coverage 89.87% 90.52% +0.64%
==========================================
Files 320 324 +4
Lines 10381 10626 +245
==========================================
+ Hits 9330 9619 +289
+ Misses 1051 1007 -44 ☔ View full report in Codecov by Sentry. |
tr4nt0r
force-pushed
the
custom_telink
branch
from
046a8ee to
7516a67
Compare
tr4nt0r
force-pushed
the
custom_telink
branch
from
a7bcfc2 to
ad6697a
Compare
tr4nt0r
force-pushed
the
custom_telink
branch
from
ad6697a to
1da86f9
Compare
tr4nt0r
changed the title
ZigbeeTlc firmware
TheJulianJES
added
the
needs review
|
ZHA seems to be ignoring the |
TheJulianJES
changed the title
ZigbeeTlc firmwareZigbeeTlc firmware quirk
Comment on lines
+195
to
+196
| off_value=1, | ||
| on_value=0, |
There was a problem hiding this comment.
Actually, I think we could also use force_inverted for this? Shouldn't really make a difference though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Adds quirk for devices that are originally Bluetooth devices but can be modified to use ZigBee with a custom firmware
Edit: Some of these are already Zigbee devices but can be differentiated by the
-zpostfix from the ones with original fw, or in case of the tuya devices because they actually also have the correct model and manufacturer set ^^Additional information
Checklist
pre-commitchecks pass / the code has been formatted using Black