Remove custom Bosch pi_heating_demand attr for RBSH-RTH0-ZB-EU

[mrrstux]

Proposed change

Remove custom Bosch pi_heating_demand attribute for RBSH-RTH0-ZB-EU due to conflicting with thermostat cooling mode.

Fixes home-assistant/core#151763.

This thermostat reports correct status through system_mode and running_mode attributes.

Checklist

• The changes are tested and work correctly
• pre-commit checks pass / the code has been formatted using Black
• Tests have been added to verify that the new code works
• Device diagnostics data has been attached

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.12%. Comparing base (2e2bbd9) to head (4c24a64).
⚠️ Report is 5 commits behind head on dev.

Additional details and impacted files

@@            Coverage Diff             @@
##              dev    #4329      +/-   ##
==========================================
- Coverage   92.13%   92.12%   -0.01%     
==========================================
  Files         358      358              
  Lines       11919    11917       -2     
==========================================
- Hits        10981    10979       -2     
  Misses        938      938              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[Sopsy]

I don't think it's a good idea to remove the sensor altogether. It's useful information.
See #4344 for a better proposed fix.

[mrrstux]

@Sopsy I would restore previous cooling related functionality until your patch is ready.

[Sopsy]

@Sopsy I would restore previous cooling related functionality until your patch is ready.

I'm not against it, especially if this one can be merged quickly (easy to review) and thus fixing the bug sooner.

However my patch is already ready from what I can do right now. The further commits I made after opening the pull request were features I found while probing the thermostat and I thought it's a good idea to include them as well to benefit everyone right away. They were features I was sorely missing after ditching the SHC.

Of the four things mentioned in additional details, there is one that I'd really want to still fix, but that can be a second patch later down the road. Namely the heater type config is still missing and I'd love to have it supported as well. There is some discussion about it in Koenkk/zigbee-herdsman-converters#9662

[TheJulianJES]

I'll take a look at the other PR as soon as possible. For now, we can merge this.

[TheJulianJES]

Thanks!