Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #4651 +/- ##
==========================================
+ Coverage 92.32% 92.35% +0.03%
==========================================
Files 371 377 +6
Lines 12190 12240 +50
==========================================
+ Hits 11254 11304 +50
Misses 936 936 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@TheJulianJES have you also looked at "vendor-specific attributes on ubisys H1" question by @barnslig posted here? -> #4587 |
5aec2d4 to
c0d7065
Compare
|
More advanced functionality (like input configuration and detached mode) will be added in a separate PR. These changes all rely on a |
DO NOT MERGE
Proposed change
This adds support for most Ubisys devices. It currently does the following:
Additional information
S1-R (5601)) requires entirely different divisors, so I'll need to check if all devices are running the latest firmware. If not, update all of them and then check if the newer firmware version requires different divisors.This would already make the updates available in Home Assistant (now).
active_powerandtotal_active_power, but this cluster does not support attribute reporting at all. All relevant attributes on this cluster are polled by default in ZHA, but only when theactive_powerentity is enabled.instantaneous_demand. This attribute supports attribute reporting, so we should only use this one primarily and disable the others by default.InstantaneousDemandis also not reportable per spec, but is reportable for this device..? This needs to be checked further).Related PRs and issues
Supersedes:
Related:
TODO:
S1-R (5601)togglecommand (only?) (edit: added triggers for default device config)Device diagnostics
TODO
Checklist
pre-commitchecks pass / the code has been formatted using Black