Add Tuya Gas Sensor _TZE204_uo8qcagc variant#4684
Open
Add Tuya Gas Sensor _TZE204_uo8qcagc variant#4684
_TZE204_uo8qcagc variant#4684Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds support for a new variant of Tuya gas sensor (_TZE204_uo8qcagc). The quirk extends the base Tuya gas alarm configuration with three additional entities: a preheat status indicator, a fault alarm sensor, and an alarm control switch.
Changes:
- Added quirk definition for
_TZE204_uo8qcagcgas sensor with specific data point mappings - Added test coverage for the new device variant
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| zhaquirks/tuya/tuya_gas.py | Added QuirkBuilder configuration for the new gas sensor variant with three custom entities (preheat sensor, fault alarm, and alarm switch) |
| tests/test_tuya_gas.py | Added test case entry for the new device model to verify gas detection functionality |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #4684 +/- ##
=======================================
Coverage 92.32% 92.32%
=======================================
Files 371 371
Lines 12190 12191 +1
=======================================
+ Hits 11254 11255 +1
Misses 936 936 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Author
|
Hi @puddly, @TheJulianJES, could you check this PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
Adds Tuya explosive gas detectors:
Additional information
Closes: #4162
Checklist
pre-commitchecks pass / the code has been formatted using Black