udpate s60zbtpf/tpg and mini-zbdim#4745
Open
lcheng33775823 wants to merge 8 commits intozigpy:devfrom
Open
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #4745 +/- ##
==========================================
- Coverage 92.32% 92.04% -0.28%
==========================================
Files 371 374 +3
Lines 12195 12373 +178
==========================================
+ Hits 11259 11389 +130
- Misses 936 984 +48 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
TheJulianJES
added
priority: medium
puddly
reviewed
Feb 12, 2026
Comment on lines
+78
to
+95
| async def _read_attributes( | ||
| self, | ||
| attribute_ids: list[t.uint16_t], | ||
| *args, | ||
| manufacturer: int | t.uint16_t | None = None, | ||
| **kwargs, | ||
| ): | ||
| """Read attributes ZCL foundation command.""" | ||
| return await super()._read_attributes( | ||
| attribute_ids, | ||
| *args, | ||
| manufacturer=foundation.ZCLHeader.NO_MANUFACTURER_ID, | ||
| **kwargs, | ||
| ) | ||
|
|
||
| @property | ||
| def _is_manuf_specific(self): | ||
| return False |
Contributor
There was a problem hiding this comment.
You can remove all of this code and just add manufacturer_code=None to every attribute definition.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.