Fix EventableCluster not listening to AttributeUpdatedEvent#4763
Draft
TheJulianJES wants to merge 1 commit intozigpy:devfrom
Draft
Fix EventableCluster not listening to AttributeUpdatedEvent#4763TheJulianJES wants to merge 1 commit intozigpy:devfrom
EventableCluster not listening to AttributeUpdatedEvent#4763TheJulianJES wants to merge 1 commit intozigpy:devfrom
Conversation
35c965b to
34713c4
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #4763 +/- ##
=======================================
Coverage 92.32% 92.32%
=======================================
Files 371 371
Lines 12190 12191 +1
=======================================
+ Hits 11254 11255 +1
Misses 936 936 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
This fixes an issue where the
EventableClusterdoes not listen toAttributeUpdatedEventevents.For example, if a Tuya datapoint is remapped to a "ZCL" attribute, which is updated using
update_attribute, it'll never fireAttributeReportedEvent, onlyAttributeUpdatedEvent. So, thezha_eventfor the attribute update is never fired.Additional information
Should hopefully address:
See related quirk:
zha-device-handlers/zhaquirks/tuya/ts0021.py
Lines 36 to 53 in 40b41de
It would probably make sense to add decent test coverage for
EventableClusterin another PR.Maybe even utilizing the Tuya datapoint remapping, or just have
update_attributebe called there.Device diagnostics
Possibly in linked HA issue or already in ZHA diagnostics.
Checklist
pre-commitchecks pass / the code has been formatted using Black